Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Allow RouteServiceProvider to be loaded more than once #49732

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

crynobone
Copy link
Member

With the new ApplicationBuilder::withRouting(), Laravel now registers RouteServiceProvider and this causes breaking changes to any applications or existing packages already extending RouteServiceProvider. While we can argue that ApplicationBuilder should only be used for new Laravel application it still cause breaking changes for multiple packages including: https://github.com/search?q=Illuminate%5CFoundation%5CSupport%5CProviders%5CRouteServiceProvider+language%3APHP+path%3A%2F%5Esrc%5C%2F%2F&type=code

@crynobone crynobone marked this pull request as ready for review January 18, 2024 11:23
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@taylorotwell taylorotwell merged commit 3b9f907 into master Jan 18, 2024
29 checks passed
@taylorotwell taylorotwell deleted the multiple-route-service-providers branch January 18, 2024 14:22
@ahmedsayedabdelsalam
Copy link
Contributor

ahmedsayedabdelsalam commented Apr 3, 2024

forcing it will make the framework route service provider run last so if i need to override loadCachedRoutes method as an example it will not work mcamara/laravel-localization#899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants