Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix adding stored columns on SQLite #49638

Merged

Conversation

hafezdivandari
Copy link
Contributor

SQLite schema grammar silently ignores adding stored columns, although it is allowed if the table is empty. This PR fixes this to avoid confusion for user and allows SQLite to handle this instead, by adding the stored column or showing a proper error message.

@hafezdivandari hafezdivandari marked this pull request as ready for review January 10, 2024 17:04
@taylorotwell taylorotwell merged commit ca52cb3 into laravel:master Jan 11, 2024
29 checks passed
@hafezdivandari hafezdivandari deleted the master-fix-add-stored-sqlite branch January 11, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants