Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fixed method and passthru in Eloquent builder both to lowercase #49324

Closed
wants to merge 1 commit into from
Closed

Conversation

bertoost
Copy link

Prevents users using the passthru list running into breaking changes and not being aware of the casing change. See PR 48852 - #48852 (comment)

Prevents users using the passthru list running into breaking changes and not being aware of the casing change. See PR 48852 - #48852 (comment)
@driesvints driesvints changed the title Fixed method and passthru in Eloquent builder both to lowercase [10.x] Fixed method and passthru in Eloquent builder both to lowercase Dec 11, 2023
@taylorotwell
Copy link
Member

Not sure we to add the performance hit of an extra array_map.

@bertoost
Copy link
Author

Cool @taylorotwell
You have introduced a change somewere on the road between 10.29 and 10.30 where our own Builder failed and we searched for the issue for a couple of hours...
I suggest an extra change to avoid this problem for anyone else in the future...
You at least could have a small talk about the approach instead of closing it without...
Too bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants