[slim-skeleton-11.x] Test Improvements

[crynobone]

Using $this->artisan() with Command::$aliases doesn't work properly at the moment. I believe this is due to how Symfony registers commands vs how Laravel resolves it with $signature.

[crynobone]

@Jubeki There seems to be some collation-related issue with MySQL 5.7 tests and MariaDB tests

[Jubeki]

@crynobone That kind of was to be expected, because MySQL 5.7 doesn't support the new collation. Based on https://laravel.com/docs/master/database#introduction I thought MySQL 8.0+ is only supported, which was one of the reasons for the change. Another reason was laravel/laravel#6239 which was reverted by laravel/laravel#6240

Now there are also discussions about reverting the Drop of MySQL 5.7 Support laravel/docs#9113

Possible solutions:

• Creating a new config entry mysql57 in Testbench-Core with the old collation and testing against that.
• In the Tests check for mysql57 and replace the collation on the fly.
• Comment out mysql57 tests. (not recommended, if MySQL 5.7 Support will be retained)

The default for new Laravel 11 Applications should be the newer collation. Even if MySQL 5.7 is supported / deprecated in Laravel 11, we can give a meaningful error solution via Ignition (See laravel/docs#9113 (comment))

[crynobone]

Is there any good approach to detect MySQL 5.7 vs 8 as well as MariaDB versions?

[Jubeki]

My only idea for now: Is the collation available or not. Will research a little bit.

[Jubeki]

The following should work (needs to be tested)

SHOW VARIABLES LIKE 'version';

# or
SELECT VERSION();

[crynobone]

@Jubeki Found a better solution, allow setting MYSQL_COLLATION and handled it via Testbench.

[Jubeki]

@crynobone cool 👍

Do you want to merge my PR #49113 into this one?

[crynobone]

Do you want to merge my PR #49113 into this one?

Yes please