Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Fix postgreSQL reserved word column names w/ guarded attributes broken in native column attributes implementation #48877

Merged
merged 5 commits into from
Nov 1, 2023
Merged

[10.x] Fix postgreSQL reserved word column names w/ guarded attributes broken in native column attributes implementation #48877

merged 5 commits into from
Nov 1, 2023

Conversation

hafezdivandari
Copy link
Contributor

@hafezdivandari hafezdivandari commented Nov 1, 2023 •
edited
Loading

Fixes #48870

The solution was to unquote quoted reserved names on PostgreSQL processor, the same approach is used on Doctrine DBAL.

Thanks @crynobone and @damiantw for reporting the issue.

crynobone
crynobone reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@crynobone crynobone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@taylorotwell taylorotwell merged commit a6db48e into laravel:10.x Nov 1, 2023
19 checks passed
@hafezdivandari hafezdivandari deleted the 10.x-fix-pgsql-issue branch November 1, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crynobone crynobone crynobone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PostgreSQL reserved word column names w/ guarded attributes broken in native column attributes implementation
3 participants
@hafezdivandari @crynobone @taylorotwell