Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Handle custom extensions when caching views #48524

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Sep 25, 2023

The view:cache command does not currently account for custom extensions, so the files are still lazily compiled.

View::addExtension('sh', 'blade');

Now when running php artisan view:cache files with the .sh extension within the configured view directory will now be cached as expected.

@timacdonald timacdonald marked this pull request as ready for review September 25, 2023 02:22
@timacdonald timacdonald marked this pull request as draft September 25, 2023 06:28
@timacdonald timacdonald marked this pull request as ready for review September 26, 2023 02:17
@taylorotwell taylorotwell merged commit ac91af7 into laravel:10.x Sep 26, 2023
19 checks passed
@timacdonald timacdonald deleted the extensions branch September 26, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants