[10.x] Fix "after commit" callbacks not running on nested transactions using RefreshDatabase or DatabaseMigrations
#48523
Commits on Sep 20, 2023
-
-
-
-
Update src/Illuminate/Database/DatabaseTransactionsManager.php
Co-authored-by: Mior Muhammad Zaki <[email protected]>
Commits on Sep 21, 2023
-
Changes the way the after commit callbacks are executed
to avoid remembering which transactions to ignore Before, we were remembering the test transaction so we could ignore it when deciding to run the after commit callbacks or not. We're still handling the after commit callbacks like that but now instead of remembering which transactions to ignore, we're always calling the DatabaseTransactionManager::commit method. The difference is that now we're passing the current transaction level to it. The method will decide to call the callbacks or not based on that level and whether or not this is on in test mode. When in tests, instead of setting the current transaction to be remembered so it could be ignored, we're now only setting the DatabaseTransactionManager to test mode. When in test mode, it will execute the callbacks when the transactions count reaches 1 (remember that the test runs in a transaction, so that's the "root" level). Otherwise, it runs the callbacks when the transactions level is on level 0 (like in production). There's also a change in the DatabaseTransactionManager::addCallback method. It now also checks if it's in test mode. When not in test mode, it only adds the callback to the execution queue if there's an open transaction. Otherwise, the callback is executed right away. When in test mode, the number of transactions has to be greater than one for it to be added to the callbacks queue.
-
-
-
-
-
Commits on Sep 22, 2023
Commits on Sep 25, 2023
-
Tests observer using afterCommit
Signed-off-by: Mior Muhammad Zaki <[email protected]>
-
-
-
-
Merge branch 'fix-create-or-first-transaction-callbacks' into 48466-r…
…edux Signed-off-by: Mior Muhammad Zaki <[email protected]>
-
-
-
Commits on Sep 26, 2023
-
-
Update src/Illuminate/Foundation/Testing/DatabaseTransactionsManager.php
Co-authored-by: Tony Messias <[email protected]>
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.