Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Improve tests for Arr::first and Arr::last #48511

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

tamiroh
Copy link
Contributor

@tamiroh tamiroh commented Sep 23, 2023

Since the tests for Arr::last were not sufficient compared to Arr::first, I added tests to testLast() that were almost identical to those included in testFirst().

In addition, there was a test for Arr::last that was not contained in Arr::first, thus I added it to testFirst().

As a result, the tests for Arr::first and Arr::last are now nearly equivalent, which is reasonable since Arr::first and Arr::last are expected to be symmetrical in their behavior.

@tamiroh tamiroh marked this pull request as ready for review September 23, 2023 14:05
@taylorotwell taylorotwell merged commit 73cbda0 into laravel:10.x Sep 25, 2023
20 checks passed
This was referenced Dec 22, 2023
@tamiroh tamiroh deleted the add-tests-arr-first-add-last branch May 7, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants