[10.x] Disable autoincrement for unsupported column type #48501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://www.doctrine-project.org/projects/doctrine-dbal/en/3.6/reference/schema-representation.html
If the new column type is not of the correct data type, disable autoincrement.
Currently, if an autoincrement column is converted to a data type that does not support autoincrement, the flag remains true, causing the primary key to not be properly registered by the DBAL schema comparator.
Not sure if this bug fix constitutes as a backwards-breaking change or not.
The following migration demonstrates how this currently affects the generated table schema. You can hack around the issue by supplying a secondary change before the column type change that would remove autoincrement, but this seems to be the wrong approach to take here.