Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Remove and update a few tearDown methods. #48381

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[10.x] Remove and update a few tearDown methods. #48381

merged 1 commit into from
Sep 13, 2023

Conversation

lucasmichot
Copy link
Contributor

This PR removes and updates a few tearDown methods.

@lucasmichot lucasmichot changed the title (feat) Remove and update a few tearDown methods. [10.x] Remove and update a few tearDown methods. Sep 13, 2023
@crynobone
Copy link
Member

What's the arguments to remove this?

@lucasmichot
Copy link
Contributor Author

lucasmichot commented Sep 13, 2023 •
edited
Loading

What's the arguments to remove this?

Mockery is imported and closed, but never used in those files; those methods do not serve any purpose.

@taylorotwell taylorotwell merged commit 5f8d1a2 into laravel:10.x Sep 13, 2023
19 checks passed
@lucasmichot lucasmichot deleted the feat/remove-useless-teardown-functions branch September 13, 2023 14:34
@edcheyjr edcheyjr mentioned this pull request Sep 19, 2023
Merged
@renovate renovate bot mentioned this pull request Oct 24, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasmichot @crynobone @taylorotwell