[10.x] Ensure createOrFirst does not return null at type level
#48214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpyw
changed the title
createOrFirst does not return nullcreateOrFirst does not return null at type level
mpyw
force-pushed
the
improve/ensure-create-or-first-not-null
branch
from
d1eda29 to
43e7694
Compare
|
Going to hold off on this one for now. Even though it should be fine. Will revisit at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
createOrFirstmethod to Eloquent #47973Replace
first()withfirstOrFail()to be safer sincefirst()may return null at the type level.