Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Adds testing helpers for Precognition #48151

Merged
merged 9 commits into from
Aug 30, 2023

Conversation

peterfox
Copy link
Contributor

@peterfox peterfox commented Aug 23, 2023

This should help anyone wanting to write a test for an endpoint using Precognition.

$this->usingPrecognition()
    ->get('/')
    ->assertPrecognitionSuccess();

@peterfox peterfox changed the title dds testing helpers for Precognition [10.x] Adds testing helpers for Precognition Aug 23, 2023
@timacdonald timacdonald self-assigned this Aug 24, 2023
@timacdonald timacdonald marked this pull request as draft August 24, 2023 07:32
@timacdonald
Copy link
Member

This is awesome, Peter. I've put a few suggestions in. Tomorrow I'll come in and do a good review to make sure it's good to go.

Tried to today, but my Git foo failed me...so unfortunately I just added a bunch of GitHub comments instead of just making the changes - sorry!

Let's leave this in review until I've had a chance to go over it in detail.

Thanks again. Very excited to see this.

@peterfox
Copy link
Contributor Author

@timacdonald thanks for reviewing! I've made the changes bar one that I left a comment on about asserting the response is a 204 status code.

@peterfox peterfox requested a review from timacdonald August 24, 2023 14:25
@peterfox peterfox marked this pull request as ready for review August 29, 2023 15:22
Copy link
Member

@timacdonald timacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Peter!

@taylorotwell taylorotwell merged commit 47767f6 into laravel:10.x Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants