-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x] Adds testing helpers for Precognition #48151
Conversation
src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php
Outdated
Show resolved
Hide resolved
This is awesome, Peter. I've put a few suggestions in. Tomorrow I'll come in and do a good review to make sure it's good to go. Tried to today, but my Git foo failed me...so unfortunately I just added a bunch of GitHub comments instead of just making the changes - sorry! Let's leave this in review until I've had a chance to go over it in detail. Thanks again. Very excited to see this. |
@timacdonald thanks for reviewing! I've made the changes bar one that I left a comment on about asserting the response is a 204 status code. |
669efc3
to
b77e562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Peter!
This should help anyone wanting to write a test for an endpoint using Precognition.