Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Markdown Mailables: Allow omitting Footer and Header when customising components #48080

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

jorisnoo
Copy link
Contributor

When the Markdown mail components are exported, it is possible to customise the templates and eg. to remove the header and footer components of the email templates. While they may be commented out in the mail/html/message.blade.php file, doing the same in the mail/text/message.blade.php file would throw an error since the mail/text/layout.blade.php file is expecting a $footer and $header variable to be set.

This admittedly very tiny change applies the current behaviour from the html template to the text version — by falling back to an empty string if the header/footer variables are not set.

@taylorotwell taylorotwell merged commit cb46ee1 into laravel:10.x Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants