[10.x] Fix parsing error in console when parameter description contains --
#48021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses an issue in the Laravel Console's signature parser where it would produce incorrect results if a parameter description contained
--
.Problem
When defining a command's signature in Laravel Console, if a parameter description included
--
, it would lead to incorrect parsing of the command. This could cause unexpected behavior or even application errors depending on how the command was defined.Example
When I generate a new command with signature:
This is will produce following result:
Solution
I've made a targeted change to the regular expression used in the
parameters
method, specifically by adding a^
to ensure that--
within a description does not interfere with the parsing process.Here's a brief summary of the change:
parameters
method to include^
, ensuring proper handling of--
within parameter descriptions.Impact
This minor yet crucial fix ensures that developers can include
--
in parameter descriptions without any parsing issues. It improves the robustness of Laravel Console's command definition and parsing capabilities.Please review and let me know if you have any questions or need further changes.