Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Remove return on void callback #47969

Merged

Conversation

gdespirito
Copy link

@gdespirito gdespirito commented Aug 4, 2023

Just a minor fix:

Facade::clearResolvedInstances() is a void function, so it does not make sense to returns it's value 😀.

image

Facade::clearResolvedInstances():
image

@gdespirito gdespirito marked this pull request as ready for review August 4, 2023 17:43
@taylorotwell taylorotwell reopened this Aug 4, 2023
@taylorotwell taylorotwell merged commit dd5c517 into laravel:10.x Aug 4, 2023
@gdespirito gdespirito changed the title [10x] Remove return on void callback [10.x] Remove return on void callback Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants