Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Improve decimal shape validation #47957

Merged
merged 2 commits into from
Aug 7, 2023
Merged

[9.x] Improve decimal shape validation #47957

merged 2 commits into from
Aug 7, 2023

Conversation

timacdonald
Copy link
Member

Back porting #47954

@timacdonald timacdonald marked this pull request as ready for review August 4, 2023 04:25
GrahamCampbell
GrahamCampbell requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR says 9.x, but the branch is 10.x?

@taylorotwell
Copy link
Member

@timacdonald can you send to 9.x branch?

@timacdonald timacdonald reopened this Aug 6, 2023
@timacdonald timacdonald changed the base branch from 10.x to 9.x August 6, 2023 22:56
@timacdonald
Copy link
Member Author

timacdonald commented Aug 6, 2023 •
edited
Loading

Updated. Thanks folks.

@taylorotwell taylorotwell merged commit 75d317a into laravel:9.x Aug 7, 2023
@timacdonald timacdonald deleted the decimal-9 branch August 7, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timacdonald @taylorotwell @GrahamCampbell