Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Adding Minutes Option in Some Frequencies #47789

Merged
merged 8 commits into from
Jul 28, 2023
Merged

[10.x] Adding Minutes Option in Some Frequencies #47789

merged 8 commits into from
Jul 28, 2023

Conversation

joaopalopes24
Copy link
Contributor

@joaopalopes24 joaopalopes24 commented Jul 20, 2023

Adding the minutes option in some frequencies, example:

$schedule->command('xxxxxx')->everyOddHour(17);
$schedule->command('xxxxxx')->everyOddHour('*/10');
$schedule->command('xxxxxx')->everyOddHour([15, 30, 45]);

$schedule->command('xxxxxx')->everyTwoHours(17);
$schedule->command('xxxxxx')->everyTwoHours('*/10');
$schedule->command('xxxxxx')->everyTwoHours([15, 30, 45]);

$schedule->command('xxxxxx')->everyThreeHours(17);
$schedule->command('xxxxxx')->everyThreeHours('*/10');
$schedule->command('xxxxxx')->everyThreeHours([15, 30, 45]);

$schedule->command('xxxxxx')->everyFourHours(17);
$schedule->command('xxxxxx')->everyFourHours('*/10');
$schedule->command('xxxxxx')->everyFourHours([15, 30, 45]);

$schedule->command('xxxxxx')->everySixHours(17);
$schedule->command('xxxxxx')->everySixHours('*/10');
$schedule->command('xxxxxx')->everySixHours([15, 30, 45]);

@taylorotwell
Copy link
Member

Tests fail.

@taylorotwell taylorotwell marked this pull request as draft July 27, 2023 14:59
@taylorotwell
Copy link
Member

If you want me to review again mark as ready for review.

@joaopalopes24
Copy link
Contributor Author

PR ready to review. Thanks @taylorotwell

@joaopalopes24 joaopalopes24 marked this pull request as ready for review July 27, 2023 16:26
@taylorotwell taylorotwell merged commit a54f988 into laravel:10.x Jul 28, 2023
@joaopalopes24 joaopalopes24 deleted the adding-minutes-option-in-cron branch August 24, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants