Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] PHP 8.3 builds #47788

Merged
merged 7 commits into from
Jul 27, 2023
Merged

[10.x] PHP 8.3 builds #47788

merged 7 commits into from
Jul 27, 2023

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Jul 20, 2023

No description provided.

@driesvints driesvints changed the title PHP 8.3 builds [10.x] PHP 8.3 builds Jul 26, 2023
$this->assertSame('image/bmp', mime_content_type($imagePath));
} else {
$this->assertSame('image/x-ms-bmp', mime_content_type($imagePath));
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a behavioral change in PHP 8.3, I'm not sure if this is something the core team is aware of?

@driesvints driesvints marked this pull request as ready for review July 27, 2023 14:16
@driesvints driesvints requested a review from taylorotwell July 27, 2023 14:16
@taylorotwell taylorotwell merged commit 7dab1c5 into 10.x Jul 27, 2023
@taylorotwell taylorotwell deleted the php83 branch July 27, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants