Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Improve typehint for Model::getConnectionResolver() #47749

Merged
merged 1 commit into from
Jul 15, 2023
Merged

[10.x] Improve typehint for Model::getConnectionResolver() #47749

merged 1 commit into from
Jul 15, 2023

Conversation

LukeTowers
Copy link
Contributor

@LukeTowers LukeTowers commented Jul 14, 2023

static::$resolver can be null, either before Model::setConnectionResolver() is called or after Model::unsetConnectionResolver() is called.

Running into an issue with static analysis complaining about this: https://github.com/wintercms/storm/actions/runs/5558377553/jobs/10153396089#step:10:16

static::$resolver can be null, either before Model::setConnectionResolver() is called or after Model::unsetConnectionResolver() is called.
LukeTowers added a commit to wintercms/storm that referenced this pull request Jul 14, 2023
@taylorotwell taylorotwell merged commit 700a0a8 into laravel:10.x Jul 15, 2023
@GrahamCampbell GrahamCampbell changed the title Improve typehint for Model::getConnectionResolver() [10.x[ Improve typehint for Model::getConnectionResolver() Jul 15, 2023
@GrahamCampbell GrahamCampbell changed the title [10.x[ Improve typehint for Model::getConnectionResolver() [10.x] Improve typehint for Model::getConnectionResolver() Jul 15, 2023
@LukeTowers LukeTowers deleted the patch-1 branch July 17, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants