Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fix inconsistent type hint for $passwordTimeoutSeconds #47414

Merged
merged 1 commit into from
Jun 12, 2023
Merged

[10.x] Fix inconsistent type hint for $passwordTimeoutSeconds #47414

merged 1 commit into from
Jun 12, 2023

Conversation

devfrey
Copy link
Contributor

@devfrey devfrey commented Jun 12, 2023

I've updated the type hint to be consistent with the type hint of the middleware's handle() method:
https://github.com/laravel/framework/blob/10.x/src/Illuminate/Auth/Middleware/RequirePassword.php#L67

An example that currently results in a static analysis error:

Route::view('/', 'home')->middleware(RequirePassword::using(passwordTimeoutSeconds: 10));

// Parameter $passwordTimeoutSeconds of static method Illuminate\Auth\Middleware\RequirePassword::using()
// expects string|null, int given.

@driesvints driesvints merged commit a796ba1 into laravel:10.x Jun 12, 2023
@driesvints
Copy link
Member

thanks!

@devfrey devfrey deleted the patch-1 branch June 13, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants