[10.x] Add shouldHashKeys to ThrottleRequests middleware #47368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ability to have rate limiter keys in a non hashed format. I believe there is no added benefit of having those hashed using
md5
orsha1
most of the time, and that could not be changed without extending and refactoring current middleware ATM.Original key:
With
false
as the setting:In our case this allows us to have data of rate limit available to outside systems like Grafana etc, without creating some other, duplicate, data.
The default setting would still be
true
, otherwise it could be adjusted in any Service Provider (f.e.RouteServiceProvider
).One thing i'm not sure is whether having a static key based setting is reasonable here. Maybe it could be added somewhere in
config/
, but i did not find a reasonable place.WDYT?
Thanks.