[10.x] Fix schedule:list to display named Jobs

[liamkeily]

The Issue

I have a project that uses named jobs in the app/Console/Kernel.php (similar to https://laravel.com/docs/10.x/scheduling#naming-unique-jobs)

class Kernel extends ConsoleKernel
{
    protected function schedule(Schedule $schedule): void
    {
        $schedule->job(new TestJob('hourly'))->name('test-job-hourly')->hourly();
        $schedule->job(new TestJob('daily'))->name('test-job-daily')->daily();
    }

The schedule:test and schedule:run commands display these correctly:

However the schedule:list command does not:

This Fix

->getSummaryForDisplay() is used by the other commands but not this one, so i have utilised it here while attempting to maintain the extra functionality that was added for Closures and Callbacks.

Testing

• • Added test coverage for instantiated jobs that have parameters, as documented at https://laravel.com/docs/10.x/scheduling#scheduling-queued-jobs but not currently tested
• • Added test coverage for named jobs

Possible Simplifications

• Share this logic via ->getSummaryForDisplay() so that all schedule commands (schedule:run, schedule:list, schedule:test) stay consistent.
• Adapt $schedule->call so that it gives an accurate description from the start, and avoids us having to piece things back together here.

[liamkeily]

For context this is the value of getSummaryForDisplay in various scinerios`

Code

dd(
            $schedule->call(function() {})->everyMinute()->getSummaryForDisplay(),
            $schedule->job(function() {})->everyMinute()->getSummaryForDisplay(),
            $schedule->job(Jobs\MyTestJob::class)->everyMinute()->getSummaryForDisplay(),
            $schedule->job(new Jobs\MyTestJob)->everyMinute()->getSummaryForDisplay(),
            $schedule->command(MyTestCommand::class)->everyMinute()->getSummaryForDisplay(),
            $schedule->call(function() {})->everyMinute()->name('named-call')->getSummaryForDisplay(),
            $schedule->job(function() {})->everyMinute()->name('named-job')->getSummaryForDisplay(),
            $schedule->job(Jobs\MyTestJob::class)->everyMinute()->name('named-test-job')->getSummaryForDisplay(),
            $schedule->job(new Jobs\MyTestJob)->everyMinute()->name('named-test-job-instance')->getSummaryForDisplay(),
            $schedule->command(MyTestCommand::class)->name('named-command')->everyMinute()->getSummaryForDisplay(),
        );

Output

"Callback" // app/Console/Kernel.php:55
"Closure" // app/Console/Kernel.php:55
"App\Jobs\MyTestJob" // app/Console/Kernel.php:55
"App\Jobs\MyTestJob" // app/Console/Kernel.php:55
"Command description" // app/Console/Kernel.php:55
"named-call" // app/Console/Kernel.php:55
"named-job" // app/Console/Kernel.php:55
"named-test-job" // app/Console/Kernel.php:55
"named-test-job-instance" // app/Console/Kernel.php:55
"named-command" // app/Console/Kernel.php:55