Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Return response from mail notification channel #47310

Merged
merged 1 commit into from
Jun 2, 2023
Merged

[10.x] Return response from mail notification channel #47310

merged 1 commit into from
Jun 2, 2023

Conversation

xalaida
Copy link
Contributor

@xalaida xalaida commented Jun 1, 2023

What is the problem?

Currently, there is no way to read the response from the mail notification channel because the MailChannel does not return the mailer response.

This response is utilized by the NotificationSender on line 148:

$response = $this->manager->driver($channel)->send($notifiable, $notification);

$this->events->dispatch(
    new NotificationSent($notifiable, $notification, $channel, $response)
);

Thus, when listening to the NotificationSent event, the response property is always null.

This issue only occurs with the mail channel. Other default channels like broadcast or database work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants