[10.x] Add the ability to extend the generic types for DatabaseNotificationCollection #47048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a simple test here https://github.com/laravel/framework/tree/10.x/types? |
added 2 commits
May 12, 2023 13:09
|
@nunomaduro Thanks for getting back. This is first time for me writing these tests. Added in da93203 - something like that? |
added 2 commits
May 12, 2023 15:20
nunomaduro
approved these changes
May 12, 2023
milwad-dev
pushed a commit
to milwad-dev/framework
that referenced
this pull request
May 12, 2023
…cationCollection (laravel#47048) * Add the ability to extend the generic types * Update DatabaseNotificationCollection.php * Remove unused * Add tests * Fix style * rm lb * Updates localtion of type tests --------- Co-authored-by: Nuno Maduro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project in currently extending the
DatabaseNotificationandDatabaseNotificationCollectionto add on top of the existing Laravel notifications.However, when extending the
DatabaseNotificationCollectionwith my own custom one, I'm getting errors, since I'm unable to provide aTKeyand aTModelto theDatabaseNotificationCollection(like I would be able to do if I were instead extending theIlluminate\Database\Eloquent\Collectionclass.Adding this markup makes it possible to add the following to my own Collection:
While without it gives me the following error in PHPStan:
Class App\Collections\NotificationCollection @extends tag contains incompatible type Illuminate\Notifications\DatabaseNotificationCollection&iterable<int, App\Models\Notification>.