[10.x] allow $sleepMilliseconds parameter receive a Closure in retry method from PendingRequest

[williamtrevisan]

The retry helper accepts either an int or a Closure. When passing a Closure object, the $attempts and the $exception would be passed, allowed users to implement their own backoff algorithm. The retry helper is used in the Pending Request class to perform request retries as well, but in this specific local, the parameters are sent after being informed by retry method that belongs to the same class mentioned, and in this method, is not accepted to inform $sleepMilliseconds as a Closure.

This pull request will allows you to inform $sleepMilliseconds parameter as a Closure or int, opening the possibility to create your own backoff algorithm for retry requests.

Example use case

Imagine a scenario where it is necessary to perform a backoff when the exception returned is of type Request Timeout (408), with this modification it would be possible to implement a dynamic strategy as follows:

Http::retry(
  times: 2,
  sleepMilliseconds: function (int $attempt, \Throwable $exception): int {
    if ($exception->getCode() === \Illuminate\Http\Response::HTTP_REQUEST_TIMEOUT) {
      return $attempt * 300000; // five minutes in milliseconds
    }
                
    return 0;
  }
);

[hicham-saddek]

This could fail in slow machines

[williamtrevisan]

Do you know another approach that I can use here to test this? Or maybe it's not necessary test that functionality knowing that is already tested in retry helper scope? Basically I have used the same approach that exists there

[CLL-GTA]

Would it be possible to do this on 9.x as well? I don't think there is an issue as the retry() helper already accepts a Closure for $sleepMilliseconds

[williamtrevisan]

Would it be possible to do this on 9.x as well? I don't think there is an issue as the retry() helper already accepts a Closure for $sleepMilliseconds

Yes, it would. I'll open a PR to implement that there.

[williamtrevisan]

Would it be possible to do this on 9.x as well? I don't think there is an issue as the retry() helper already accepts a Closure for $sleepMilliseconds

Yes, it would. I'll open a PR to implement that there.

Well, I have opened a PR to make it possible in 9.x, but folks from laravel core said that 9.x is not open for new features, and people needs to upgrade to 10.x. You can see this here

[CLL-GTA]

Well, I have opened a PR to make it possible in 9.x, but folks from laravel core said that 9.x is not open for new features, and people needs to upgrade to 10.x. You can see this #47213

Well, that's disappointing, but thanks for trying.