Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Update database version check for lock popping for PlanetScale #44925

Merged
merged 2 commits into from
Nov 14, 2022
Merged

[9.x] Update database version check for lock popping for PlanetScale #44925

merged 2 commits into from
Nov 14, 2022

Conversation

narciero
Copy link
Contributor

PlanetScale (Vitess) does not support SKIP LOCKED.

This issue was addressed previously in #44027 however PlanetScale seems to have changed their version string suffix from -vitess to -PlanetScale.

> DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION)
= "8.0.23-PlanetScale"

@narciero narciero requested a review from fragkp November 13, 2022 16:46
fragkp
fragkp reviewed Nov 13, 2022
View reviewed changes
Copy link
Contributor

@fragkp fragkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@taylorotwell taylorotwell merged commit 5f134c7 into laravel:9.x Nov 14, 2022
@narciero narciero deleted the patch-1 branch November 14, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fragkp fragkp fragkp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narciero @fragkp @taylorotwell