[9.x] Remove argument assignment for console #44888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok reverting is the best option then. I'll take a look again when I have time; i agree that some of the current implementation seems a bit brittle. So does some of the code in Symfony because they also seem to just ignore any exception following from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #44662 by @bert-w. It seems this doesn't exactly works as expected because incorrect arguments are assigned: #44877. I spent a great deal today looking into a fix but always managed to run into failing integration tests. Since this part of Laravel is too brittle it seemed to me to be the best choice to revert the PR to get back to the state it was instead of having a half baked implementation.
If we ever want to pursue this we'll need to make sure that the arguments of the input doesn't contains the command name as the issue in #44877 describes.