Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix Collection::combine return docblock #44865

Merged
merged 1 commit into from
Nov 7, 2022
Merged

[9.x] Fix Collection::combine return docblock #44865

merged 1 commit into from
Nov 7, 2022

Conversation

Josh-G
Copy link
Contributor

@Josh-G Josh-G commented Nov 7, 2022

Previously, the combine docblock always used the template type of the first collections keys. It should be TValue since we're combining the values of both collections.

Added a type assertion as well, without this change it fails with

  :605   Expected type Illuminate\Support\Collection<string, string>, actual: Illuminate\Support\Collection<int, string>  

@nunomaduro nunomaduro merged commit f14b34b into laravel:9.x Nov 7, 2022
@nunomaduro
Copy link
Member

Thank you!

@Josh-G Josh-G deleted the patch-1 branch November 7, 2022 12:22
@GrahamCampbell GrahamCampbell changed the title Fix Collection::combine return docblock [9.x] Fix Collection::combine return docblock Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants