[9.x] Fix QueryBuilder whereNot with array conditions #44083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently yields
not ( not foo = 1 and not bar = 2 )
while I would expect this to implictly become a nested clause
not ( foo = 1 and bar = 2 )
.The commits in this PR are deliberately threefold:
whereNested
: aesthetically superfluous parentheses (but sql doesn't care).Note: the PR only tackles
Query\Builder
. The same principle probably applies forEloquent\Builder