Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Test Improvements #39877

Merged
merged 4 commits into from
Dec 3, 2021
Merged

[8.x] Test Improvements #39877

merged 4 commits into from
Dec 3, 2021

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Dec 3, 2021 •
edited
Loading

  • Replace Capsule (using in-memory sqlite) test to extends DatabaseTestCase.
  • Replace mocking Container to asserts on events and use Event::fake()
  • Purge all database connections on tearDown().

Signed-off-by: Mior Muhammad Zaki [email protected]

@crynobone
Test Improvements
1c9375b 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone closed this Dec 3, 2021
@crynobone crynobone reopened this Dec 3, 2021
@crynobone
wip
8a2fb4c 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
58df662 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
5aa1489 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@driesvints
Copy link
Member

Nice @crynobone! Now we can re-enable the Postgres build on master after this is merged.

@taylorotwell taylorotwell merged commit 1f70040 into laravel:8.x Dec 3, 2021
@crynobone crynobone deleted the patch-test branch December 3, 2021 21:05
@crynobone crynobone mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crynobone @driesvints @taylorotwell