Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add missing singular minute() call #39050

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

owenvoke
Copy link
Contributor

@owenvoke owenvoke commented Oct 1, 2021

It looks like a minute() call was missed out from #38815, however I'm not entirely sure if this was intentional.

This works the same way as the existing singular calls for the other Wormhole methods:

// Before
$this->travel(1)->minutes();
$this->travel(-1)->minutes();

// After
$this->travel(1)->minute();
$this->travel(-1)->minute();

@taylorotwell taylorotwell merged commit 568e741 into laravel:8.x Oct 1, 2021
@GrahamCampbell GrahamCampbell changed the title feat: add missing singular minute() call [8.x] Add missing singular minute() call Oct 1, 2021
@owenvoke owenvoke deleted the feature/minute branch October 2, 2021 12:41
victorvilella pushed a commit to cdsistemas/framework that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants