[8.x] Add the password reset URL to the toMailCallback #38552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful to receive the generated reset URL in the callback, because if we want to only change the mail template texts (ResetPassword::toMailUsing(function($user, $token) {}) we have to generate it ourselves.
Backwards compatibility is kept, as it is a new parameter.
GrahamCampbell
changed the title
|
FYI this is not backwards compatible. |
|
@squarebeard can you send in a pr? |
|
I meant "Adapting my code to this change was easy." |
|
Laravel NOVA is not compatible. Please alert to David |
|
I've sent in a PR to revert this: #38711 |
taylorotwell
pushed a commit
that referenced
this pull request
Sep 8, 2021
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
* Add the password reset URL to the toMailCallback
It is useful to receive the generated reset URL in the callback, because if we want to only change the mail template texts (ResetPassword::toMailUsing(function($user, $token) {}) we have to generate it ourselves.
Backwards compatibility is kept, as it is a new parameter.
* Update ResetPassword.php
Co-authored-by: Taylor Otwell <[email protected]>
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to receive the generated reset URL in the callback, because if we want to only change the mail template texts (
ResetPassword::toMailUsing(function($user, $token) {}) we have to generate it ourselves.Backwards compatibility is kept, as it is a new parameter.