Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "resolution" order to route:list command #37824

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

antonioribeiro
Copy link
Contributor

This can be handy when debugging resolution problems, as we can see routes in the exact order they will be resolved.

This can be handy when debugging resolution problems, as we can see routes in the exact order they will be resolved.
@taylorotwell
Copy link
Member

Is this the same as just not passing a sort at all?

@antonioribeiro
Copy link
Contributor Author

Not the same, because the default is sort by uri:

[
    'sort', null, InputOption::VALUE_OPTIONAL, 
    'The column (resolution, domain, method, uri, name, action, middleware) to sort by', 
    'uri' <= DEFAULT
],

@taylorotwell taylorotwell merged commit 32f21da into laravel:8.x Jun 25, 2021
@Synchro
Copy link
Contributor

Synchro commented Jun 25, 2021

@antonioribeiro if you are trying to figure out exactly which route is being used for a URL and/or domains, take a look at my fork that does that much more accurately by actually resolving the routes rather than leaving you to match route patterns yourself.

@antonioribeiro
Copy link
Contributor Author

So you are advertising your Laravel fork on the actual Laravel framework repository, @Synchro? 🤷‍♂️
Thanks, but no thanks!

@Synchro
Copy link
Contributor

Synchro commented Jun 25, 2021

Only because I thought it might be useful for what it sounded like you were trying to do, and my PR for it was rejected. There's no reasonable way for me to turn it into an extension, so it's otherwise dead code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants