[8.x] Cast JSON strings containing single quotes

[dees040]

When using the castAsJson() method my tests would sometimes fail because the faker created a string which contained a single quote. It would generate the following error:

Illuminate\Database\QueryException : SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's Bar"}' AS JSON))' at line 1 (SQL: select count(*) as aggregate from table where (column = CAST('{"for":"Baz's Bar"}' AS JSON)))

Example code to reproduce the bug:

$this->assertDatabaseHas('table', [
    'column' => $this->castAsJson([
        'for' => "Baz's Bar",
    ]),
]);

This pull request tries to fix that bug. Hopefully, it's of any use.

[taylorotwell]

When you say it "tries to fix it" - does it fix it? Did you actually try the fix and confirm the bug is fixed? 😄

[dees040]

Thanks for your reply. My bad, I could have described that better. I've tested it and It indeed fixed the bug. What I meant with "tries to fix it" is the way I did it. I couldn't find that many places where strings got quoted like this.