[8.x] Fixes for Stringable (updated) #37613
Conversation
|
I've also taken the opportunity to add further test cases for echo handling. |
|
If having the declaration at the top is undesirable, we could also update the public function stringable($class, $handler = null)
{
if ($class instanceof Closure) {
[$class, $handler] = [$this->firstClosureParameterType($class), $class];
}
$this->echoHandlers[$class] = $handler;
app('view')->share('__bladeCompiler', app('blade.compiler'));
}which would achieve exactly the same result (caching the bladeCompiler) but move its declaration outside of the compiled template. |
|
@ibrasho has updated the previous PR with a different method of accomplishing this, so if you prefer that way feel free to close this PR 👍 |
|
Does this also fix ternary conditionals in Blade? I had a few cases of the following failing since this update (as I was so excited to to use this great feature, thank you!): {{ $model->exists ? 'Update' : 'Create' }}Resulting in this situation: https://stackoverflow.com/questions/61432488/php-error-unparenthesized-a-b-c-d-e-is-deprecated-use-either-a Wrapping them in parentheses fixes it, but it wasn't an issue before the last update: {{ ($model->exists ? 'Update' : 'Create') }} |
This is an extension of (and replacement for) #37603.
One of the concerns raised was the amount of times the
BladeCompilerwould need to be resolved from the container. In this PR, if an echo handler has been defined, the compiled view will have a variable prepended to it with the value of the blade compiler, and all handler statements will then reference this variable rather than resolving a fresh instance.I have kept the reformatting from @ibrasho's PR.
This also handles the semicolon issue mentioned in livewire/livewire#2935 by removing the semicolon at the end of an echo statement.
Here is an example of the new compiled output when an echo handler is found.