[8.x] Explicitly set unit of sleep of retry function #36810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the retry function it was not clear from the function signature function what the sleep timer was? seconds, milliseconds or microseconds.
You could look at the code and discover you're using usleep * 100 to get to ms
Or you could look at the docs on laravel.com to see the code example
https://laravel.com/docs/8.x/helpers#method-retry
This PR just aims to save someone a few clicks and confusion