[6.x] Fix the return type of spop for phpredis #36106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zingimmick
changed the title
zingimmick
changed the title
driesvints
reviewed
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the return type of
spopfor phpredis and add missingspoptest to redis connection.Current Behaviour
When called
spopwithout the count argument, it returns array.Fixed Behaviour
When called
spopwithout the count argument, it returns string.Reference
Return value of SPOP
When called without the count argument:
Bulk string reply: the removed member, or nil when key does not exist.
When called with the count argument:
Array reply: the removed members, or nil when key does not exist.