Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Refresh the retryUntil time on job retry #35780

Merged
merged 3 commits into from
Jan 5, 2021
Merged

[8.x] Refresh the retryUntil time on job retry #35780

merged 3 commits into from
Jan 5, 2021

Conversation

Orrison
Copy link
Contributor

@Orrison Orrison commented Jan 5, 2021

Much like how attempts is reset when a job is retried using the with the queue:retry command, this will now make it so the retryUntil time is refreshed before being put back onto the queue. Using the jobs own retryUntil method of course!

Without this, jobs that use a custom retryUntil method will always fail with a MaxAttemptsExceededException if put back onto the queue with the queue:retry command AFTER the first time the job is run and retryUntil is set in the job payload.

This will provide a benefit to users who want to retry jobs sitting in failed_jobs with a custom retryUntil and don't want to have to update that value manually in the DB

@taylorotwell taylorotwell merged commit cdcc60b into laravel:8.x Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants