Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix postgres reference parsing #35530

Merged
merged 4 commits into from
Dec 10, 2020

Commits on Dec 8, 2020

  1. "Normalize" the search_path parsing behavior

    Primarily, these changes "normalize" the search_path parsing behavior such that the new parseSearchPath() method returns the same result whether the search_path input is an array (with one or more schemas), a string with one schema, or a string of comma-separated schemas.
    
    This method's presence makes it much simpler to retrieve the search_path as configured on the connection and use it for more complex schema-related grammar construction.
    cbj4074 committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    20fc31c View commit details
    Browse the repository at this point in the history
  2. Fix PostgreSQL object reference parsing

    The manner in which object references were parsed in certain scenarios caused methods such as hasTable() to return incorrect results.
    
    Among other issues, the underlying SQL grammar omitted the "table_catalog" (i.e., database) in the WHERE clause, which caused inaccurate results in certain cases, e.g., the method returned true incorrectly because a schema and table with the same name exist in a *different database*.
    cbj4074 committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    76933a3 View commit details
    Browse the repository at this point in the history
  3. Apply Style-CI fixes

    cbj4074 committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    c630b8e View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Configuration menu
    Copy the full SHA
    7128e69 View commit details
    Browse the repository at this point in the history