[8.x] Change Wormhole to use the Date Factory #35421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use
CarbonImmutable
by default in an app I'm building, and got caught up in a wormhole issue when trying to travel into the future.Basically, this example currently doesn't work as expected:
This PR fixes the issue by making sure the
Wormhole
class referencesIlluminate\Support\Facades\Date
facade instead ofIlluminate\Support\Carbon
.Also added a test to make sure it works as expected.