Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Move the getRelationCountHash method to parent class (Relation) #35394

Merged
merged 3 commits into from
Nov 29, 2020

Conversation

khalilst
Copy link
Contributor

The getRelationCountHash was duplicted on 4 places and all of them inherit from 'Relation'.
I have just moved the above method and $selfJoinCount to parent Relation class.

@GrahamCampbell GrahamCampbell marked this pull request as draft November 27, 2020 20:28
@GrahamCampbell GrahamCampbell changed the title Move the getRelationCountHash method to parent class (relation) [8.x] Move the getRelationCountHash method to parent class (relation) Nov 27, 2020
@khalilst khalilst changed the title [8.x] Move the getRelationCountHash method to parent class (relation) [8.x] Move the getRelationCountHash method to parent class (Relation) Nov 27, 2020
@khalilst khalilst marked this pull request as ready for review November 27, 2020 20:36
@taylorotwell taylorotwell merged commit 2b4b18c into laravel:8.x Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants