[8.x] Schema Dump: check error message with command option instead of table name #34233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command option: column-statistics Table name : column_statistics
roberto-butti
changed the title
driesvints
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short version: fix typo in message error
Long version: if the first try in the command line is to use "--column-statistics=0" and you have an error because the option is not supported by your client (too old) you will have a message about the missing option (column-statistics)
Instead, if the first try is to not use "--column-statistics=0" option and you have an error because you have a new client and a old server (mysql5.7) you will have a message about the missing table ("column_statistics")
So with this implementation (where it is used with "--column-statistics=0") the error will be about "column-statistics"
Command option: column-statistics
Table name : column_statistics
Tested with mysqldump 5.7 , mysqldump 8, mysqld 5.7, mysqld8