[6.x] Support PHP 8's reflection API #33039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
force-pushed
the
php8-reflection
branch
from
65e4c13 to
bdbcc2c
Compare
nikic
reviewed
Jun 30, 2020
| @@ -157,16 +157,20 @@ protected static function getCallReflector($callback) | |||
| protected static function addDependencyForCallParameter($container, $parameter, | |||
| array &$parameters, &$dependencies) | |||
| { | |||
| if (array_key_exists($parameter->name, $parameters)) { | |||
| $dependencies[] = $parameters[$parameter->name]; | |||
| if (array_key_exists($parameter->getName(), $parameters)) { | |||
There was a problem hiding this comment.
Why was ->name changed to ->getName() everywhere? If that property no longer exists, that wasn't intentional and should be fixed on our side.
There was a problem hiding this comment.
That wasn't a fix, per say. It was just a move to use the documented methods for getting the name. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
->getClass()was actually never documented in PHP 5/7 and was never intended to be used by the public. It has been deprecated in PHP 8 for removal soon after. We should use the documented reflection parameter APIs only.This fixes, for example: