Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Prevent long URLs from breaking email layouts #32189

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

imacrayon
Copy link
Contributor

Long URLs will break the default email notification layout because they don't wrap:

Screen Shot 2020-03-31 at 5 17 38 PM

I added a new utility class to the default mail theme and modified the notification layout so that URLs in notifications are forced to wrap:

Screen Shot 2020-03-31 at 5 17 12 PM

I'd consider this a breaking change because I had to update a translation string in the notification layout.

@imacrayon imacrayon force-pushed the message-urls branch 2 times, most recently from ee3e986 to 8dba2ad Compare March 31, 2020 23:14
@imacrayon imacrayon changed the title Message urls Prevent long URLs from breaking email layouts Mar 31, 2020
@GrahamCampbell GrahamCampbell changed the title Prevent long URLs from breaking email layouts [8.x] Prevent long URLs from breaking email layouts Apr 1, 2020
@GrahamCampbell
Copy link
Member

This fix should probably go into 6.x.

@driesvints
Copy link
Member

I agree with @GrahamCampbell.

@imacrayon
Copy link
Contributor Author

👍 thanks for the fast feedback. I’ll get this branch re-targeted

@imacrayon imacrayon changed the base branch from master to 6.x April 2, 2020 13:27
@driesvints driesvints changed the title [8.x] Prevent long URLs from breaking email layouts [6.x] Prevent long URLs from breaking email layouts Apr 2, 2020
@taylorotwell taylorotwell merged commit 59dca48 into laravel:6.x Apr 2, 2020
@Daniel-Mendes
Copy link

Daniel-Mendes commented Apr 16, 2020

Your modifications brake the caouecs/Laravel-lang/ package because you removed the actionURL, see this issue and this PR.

So we can't translate the footer content anymore.

Edit: not a problem just have to update the caouecs/laravel-lang project because we don't need to translate an URL.

@imacrayon imacrayon deleted the message-urls branch April 20, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants