[6.x] Add a no migrations event #31289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a (much more) simplified version of #29503
Reasoning:
Currently, there are no migration events fired when there are no migrations to run or to rollback. However, there might be use cases (as described in the above PR) where events are still desirable.
The other PR refactored the
Migratorquite a bit. And was also breaking because currently no events are fired, and with the update, the events would always be fired. So if your code expects the events to be only fired when migrations are available it would break.The suggested change is a new event
NoMigrationsthat will only be fired when no migrations will be executed. This is a new feature and does not break any code.