Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Adds missing options for PhpRedis - Part 2 #31262

Closed
wants to merge 3 commits into from
Closed

[6.x] Adds missing options for PhpRedis - Part 2 #31262

wants to merge 3 commits into from

Conversation

danijelk
Copy link
Contributor

In extension of #31182 we managed to find the issue with serializer tests failing once it was truly enabled. Turns out when using rawCommand in redis that it indeed does send commands in raw format and skips over the native serialiser.

So in order to utilise the serializer, we need to pass data through the native ->command() method.

And since special redis options (XX, NX...) need to be sent as an array, we need to cleanup parameters before passing data to command() method as per phpredis definitions.

We also added a new test for compression option (if compiled), which finally enabled native compression in redis.

Added options for native phpredis compression using LZF/ZSTD
@driesvints driesvints dismissed their stale review January 28, 2020 12:09

Changes made

@taylorotwell
Copy link
Member

It's unclear what is happening in the code. Extract a method or two so it's more understandable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants