[6.x] Adds missing options for PhpRedis - Part 2 #31262
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In extension of #31182 we managed to find the issue with serializer tests failing once it was truly enabled. Turns out when using rawCommand in redis that it indeed does send commands in raw format and skips over the native serialiser.
So in order to utilise the serializer, we need to pass data through the native ->command() method.
And since special redis options (XX, NX...) need to be sent as an array, we need to cleanup parameters before passing data to command() method as per phpredis definitions.
We also added a new test for compression option (if compiled), which finally enabled native compression in redis.