Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix can't insert float into MySQL with PHP 7.3 #31100

Merged
merged 2 commits into from
Jan 13, 2020

Commits on Jan 10, 2020

  1. Fix can't insert float into MySQL with PHP 7.3

    When inserting a float value into MySQL via the Illuminate\Database package when using at least PHP 7.3, the value is converted to an int.
    
    The bug has been reported a few times before:
    
    * laravel#30435
    * illuminate/database#246
    
    PR laravel#16069 introduced logic to the MySQLConnection that cast floats to ints to address a comparison problem with JSON columns, which was reported in issue laravel#16063. This does not seem to cause a problem with PHP 7.1 and below but causes the float to lose it's decimal places when using PHP 7.3. I have not tested with PHP 7.2.
    
    Given we have the following MySQL table:
    
    ```
    CREATE TABLE `zip_codes` (
      `zip_code` varchar(255) NOT NULL,
      `latitude` decimal(15,10) NOT NULL,
      `longitude` decimal(15,10) NOT NULL
    )
    ```
    
    When we execute the following using Artisan Tinker:
    
    ```php
    DB::table('zip_codes')->delete();
    
    // Using the same values
    $lat = -0.2;
    $lon = 0;
    $sql = 'INSERT INTO zip_codes (latitude, longitude, zip_code) VALUES (:lat, :long, :zip)';
    
    // We insert the first by using PDO directly
    $values = [':lat' => $lat, ':long' => $lon, ':zip' => 1];
    DB::connection()->getPdo()->prepare($sql)->execute($values);
    
    // Then the second by using Eloquent
    DB::table('zip_codes')->insert(['latitude' => $lat, 'longitude' => $lon, 'zip_code' => 2]);
    
    // Then pull them both.
    DB::table('zip_codes')->get();
    ```
    
    Then we should see both records with -0.2 as the latitude. But only the first has the value, and the second row is zero.
    Chekote committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    f6530aa View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. Add integration tests

    Chekote committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    850425d View commit details
    Browse the repository at this point in the history