Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fixed breaking compatability with multi-schema postgres #30555

Closed
wants to merge 4 commits into from

Conversation

raymondtri
Copy link
Contributor

The Postgres engine supports a multi-schema search path, and parts of the PostgresBuilder do not.

This PR addresses multiple schema support in a non-breaking way for 6.x.

Furthermore, to give more granular control, I allowed the $excludedTables portion of the dropAllTables() method to be set via configuration values, while gracefully falling back to the original value.

This level of granularity is particularly important when it comes to postgresql extensions and the tables they sometimes create.

@driesvints
Copy link
Member

Changing the method signature like this is a breaking change unfortunately and should target master instead.

@taylorotwell
Copy link
Member

I think if you wanted to do this you would need to handle strings OR arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants