[6.x] Fix belongsTo relation when using multiple database connections #30185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could previously cause errors where the owner belonged to another database and the child to the default one.
driesvints
changed the title
|
We can't call a global config helper in the middle of an Eloquent method. |
|
The issue still persists, so I've tried different solutions, but got stuck with testing. If anyone would like to give me a hand fixing this issue, feel free! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Could previously cause errors where the owner belonged to another database and the child to the default one.
Fix
This PR tries to fix that by using the correct relational connection.
Feel free to provide feedback or tweak whenever needed.
Possibly related to #29935.
This pull request was built together with @jordyvanderhaegen.
Update
I see the tests fail on the use of config.
Two possible options:
setConnection, as getConnection will fall back to the right one when a model has no custom connection. Might cause elsewhere thoughAnyone who could point me in the right direction would be a great help!