[5.8] Fix top level wildcard validation for 'distinct' #29499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone writes validation rules like this:
it doesn't work as expected.
Why?
The
implicitAttributes
array inValidator
class stores the mapping of 'unparsed' rule to 'parsed' rule.For the given rule, it is like:
So, when this array is searched to get the
key
of "0.id", it finds*
instead of*.id
because of loose comparison match between"0.id"
and0
.This scenario can be avoided if all the parsed rule are stored as
string
, which I did in this PR.I've also added tests to verify the correctness of my solution.
This PR will fix #29190